test intrinsic fallback bodies with Miri #140903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
The Miri subtree was changed cc @rust-lang/miri |
WaffleLapkin
approved these changes
May 11, 2025
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#140792 (Use intrinsics for `{f16,f32,f64,f128}::{minimum,maximum}` operations) - rust-lang#140795 (Prefer to suggest stable candidates rather than unstable ones) - rust-lang#140865 (Make t letter looks like lowercase rather than uppercase) - rust-lang#140878 (Two expand-related cleanups) - rust-lang#140882 (Split duration_constructors to get non-controversial constructors out) - rust-lang#140886 (Update deps of bootstrap for Cygwin) - rust-lang#140903 (test intrinsic fallback bodies with Miri) r? `@ghost` `@rustbot` modify labels: rollup
|
Something seems to have gone wrong, it doesn't look like it ran any tests in the CI run. |
bors
added
S-waiting-on-author
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2025
Rollup merge of rust-lang#140903 - RalfJung:fallback-body-tests, r=WaffleLapkin test intrinsic fallback bodies with Miri `@Urgau` noted in rust-lang#140792 that fallback bodies our backends don't use are untested... which is correct, and it is a problem. So this adds a testing-only flag to Miri to force the use of fallback bodies, and adds a run of the Miri test suite with that flag to CI. This should not take much more than a minute so I hope it's fine? Let's see how long it actually takes. While at it, I made that test run also enable MIR optimizations. Miri's CI has a run with that, and it has caught mir-opt bugs in the past -- this way we'd see the CI failure earlier. r? `@scottmcm`
|
Damn, the rollup landed it.^^ Will post a follw-up... |
|
Thanks for working on this! I'd be quite happy to remove the one-off testing for some of them in rust/library/core/src/intrinsics/fallback.rs Lines 3 to 5 in d97326e that I'd added, but not done consistently. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 17, 2025
checktools.sh: fix bashism Follow-up to rust-lang#140903. Turns out `tests/{pass,panic}` only properly expands in bash, not in dash. :/ r? `@WaffleLapkin`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 17, 2025
Rollup merge of rust-lang#140917 - RalfJung:checktools, r=WaffleLapkin checktools.sh: fix bashism Follow-up to rust-lang#140903. Turns out `tests/{pass,panic}` only properly expands in bash, not in dash. :/ r? `@WaffleLapkin`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
May 18, 2025
checktools.sh: fix bashism Follow-up to rust-lang/rust#140903. Turns out `tests/{pass,panic}` only properly expands in bash, not in dash. :/ r? `@WaffleLapkin`
|
@scottmcm yeah those can probably be removed now, just make sure the relevant intrinsic has coverage in Miri. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Urgau noted in #140792 that fallback bodies our backends don't use are untested... which is correct, and it is a problem. So this adds a testing-only flag to Miri to force the use of fallback bodies, and adds a run of the Miri test suite with that flag to CI. This should not take much more than a minute so I hope it's fine? Let's see how long it actually takes.
While at it, I made that test run also enable MIR optimizations. Miri's CI has a run with that, and it has caught mir-opt bugs in the past -- this way we'd see the CI failure earlier.
r? @scottmcm